alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.03k stars 779 forks source link

Question: Locked to Node 8.x.x #89

Closed mblarsen closed 5 years ago

mblarsen commented 5 years ago

Any reason why the package.json locks the node version to 8.x.x? Could we change it to ">=8.x.x"?

kimmobrunfeldt commented 5 years ago

To lock down the major node version. I think it's always wise to lock down the major, because stuff can automatically break according to semver (unless node has some additional guarantees). I'll bump the version to 10 which is a good LTS now.