add option to create a browser by connecting to a chrome websocket endpoint

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.

MIT License

7.01k stars 774 forks source link

Closed lanre-ade closed 4 years ago

lanre-ade commented 5 years ago

This comes in handy when sharing an already running instance of headless chrome between multiple services

kimmobrunfeldt commented 5 years ago

Thanks for the contribution, sounds like a potentially useful configuration. Changes that need to be done before merge:

Fixing lint errors
Have a shared base configuration object instead of duplicating ignoreHTTPSErrors and sloMo options. This will inevitably lead to situation where the other one will miss a newly added option because of a maintenance mistake.
Rebase with existing commits. The HTML setContent fix is in master already.

lanre-ade commented 5 years ago

@kimmobrunfeldt Made the changes you recommended. Let me know if this is good to go

kimmobrunfeldt commented 4 years ago

Thanks for the contribution!