quick fix get_stock_information to work with the latest html changes

alvarobartt / investpy

Financial Data Extraction from Investing.com with Python

https://investpy.readthedocs.io/

MIT License

1.63k stars 377 forks source link

quick fix get_stock_information to work with the latest html changes #314

Closed alexis closed 3 years ago

alexis commented 3 years ago

Fixing this error (caused by HTML changes on investpy.com):

>>> df = investpy.stocks.get_stock_information(stock = "LPL", country = "United States")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/investpy/stocks.py", line 1146, in get_stock_information
    raise RuntimeError("ERR#0004: data retrieval error while scraping.")

alvarobartt commented 3 years ago

Hi @alexis, thank you for this fix! 👍🏻 Could you please change the target branch of the PR so that instead of master you create the PR over dev, as I'm planning to merge that branch later today and upload investpy v1.0.4. Thanks!

I think this issue #315 recently opened by @SLakhani1 refers to the same bug.

alexis commented 3 years ago

Changed!

alvarobartt commented 3 years ago

Great work @alexis! 💪🏻