search

alvarobartt / investpy

Financial Data Extraction from Investing.com with Python
https://investpy.readthedocs.io/
MIT License
1.59k stars 375 forks source link

Data retrieved from SearchObj is overwritten with None #333

Closed danilogalisteu closed 3 years ago

danilogalisteu commented 3 years ago

In search_obj.py method _convert2df, the result is overwritten with None due to an inplace argument.

typhoon71 commented 3 years ago

I can confirm the fix solves the issue; this is breaking investpy badly and I suggest a quick release to push this fix. I corrected it myself locally once I read what it was, but a hotfix should be preferred for the masses. Good job danilogalisteu spotting the cause, it's a stupid error I sometime do myself too (forgetting inplace methods are... inplace).

alvarobartt commented 3 years ago

Thanks a lot @danilogalisteu! :fire: You rock!

Hi @typhoon71, thanks for confirming that it works as expected, I'm merging it ASAP so as to release investpy v1.0.6. Stay tuned, and sorry for the inconvenience...

alvarobartt commented 3 years ago

You can now install the latest investpy release as it follows:

pip install investpy==1.0.6

Thanks for the support! :muscle::fire: