search

alvarobartt / investpy

Financial Data Extraction from Investing.com with Python
https://investpy.readthedocs.io/
MIT License
1.66k stars 379 forks source link

_recent_data does not give close, but price #375

Closed enghseb closed 3 years ago

enghseb commented 3 years ago

After experimenting with getting the close for US10Y, I've come to the conclusion that the information shown when using: investpy.bonds.get_bond_recent_data("U.S 10Y", as_json=False, order='ascending', interval='Daily')

Is not the close, but rather the value that's shown on the following page as "price": https://www.investing.com/rates-bonds/u.s.-10-year-bond-yield-historical-data

While it'd make sense for price and close to be the same value, they are not. The "price" does not match the "Prev. Close" value that can be found on the overview page here: https://www.investing.com/rates-bonds/u.s.-10-year-bond-yield

I'm guessing this is the case for more type of instruments than bonds.

The only way I've managed to obtain the latest close price, is by using investpy.bonds.get_bonds_overview(country, as_json=False)

alvarobartt commented 3 years ago

Hi @enghseb, you are right! :hugs:

I'll change that so that the output does not contain Close but Price as well as the Change % as that's more accurate! So sorry in advance, I didn't even realize... I'll try to solve this later this week.

alvarobartt commented 3 years ago

BTW I think that the same happens with investpy.search_quotes when retrieving data from bonds, as well as in investpy.get_bond_historical_data :+1:

alvarobartt commented 3 years ago

Hi @enghseb I've been exploring this issue, and it seems that Investing.com changed the column name so that now instead of Close the column name is Price, I guess that changing from Close to Price is a major change since a lot of people is using investpy right now... :confused:

Anyway, what I'll do is including the Change Pct value since it is currently missing, if you have a more detailed explanation on why did the name change from Close to Price just let me know!

Thank you!

alvarobartt commented 3 years ago

All this new features will be available in the next investpy release which will be v1.0.7 and will come later this weekend :fire:

Stay tuned in the milestone so as to check the progress of all the issues/bugs/features that will be tackled during this sprint at https://github.com/alvarobartt/investpy/milestone/2

alvarobartt commented 3 years ago

Here's a list with all the supported financial products from Investing.com and the historical/recent data they provide for each type of product:

alvarobartt commented 3 years ago

Hi @enghseb, the new release is already out! :fire:

You can already install it using either pip install investpy==1.0.7 or just update the current version that you are using with pip install investpy --upgrade. Thanks a lot for your support! :+1:

For more information about this new release, you should check investpy v1.0.7 Release :balloon: