search

alvarobartt / pyrtfolio

Python package to generate stock portfolios
https://investpy-portfolio.readthedocs.io
GNU General Public License v3.0
148 stars 26 forks source link

Typo in the readme example #4

Closed typhoon71 closed 4 years ago

typhoon71 commented 4 years ago

There's a little typo in the readme:

portfolio.add_stock(stock_aymbol='ELE',

should be:

portfolio.add_stock(stock_symbol='ELE',

It's in the front page so I suppose you may care about it.

alvarobartt commented 4 years ago

Hi @typhoon71! Thanks a lot, you can fork the repo, update the README and open a Pull Request so that I can merge the changes/improvements you make into the master branch. I can change it too, but since you spotted it, I think it's better that you solve it so as to get credits for contributing. Thank you!

typhoon71 commented 4 years ago

Done.

alvarobartt commented 4 years ago

You need to create the pull request to the master branch, since you created the pull requests into your own fork.

typhoon71 commented 4 years ago

Now?

alvarobartt commented 4 years ago

Steps: New Pull request at https://github.com/alvarobartt/pyrtfolio/pulls -> Compare across forks -> Select your fork -> Describe all the feature, fixes, etc that you solved within your fork