search

alvarobartt / pyrtfolio

Python package to generate stock portfolios
https://investpy-portfolio.readthedocs.io
GNU General Public License v3.0
147 stars 26 forks source link

pyrtfolio forces installation of pandas 0.25.3 #5

Closed typhoon71 closed 4 years ago

typhoon71 commented 4 years ago

When installing pyrtfolio pandas 0.25.3 will be installed, even if there's already pandas 1.0.4 installed.

I think this should be fixed.

alvarobartt commented 4 years ago

Hi again @typhoon71! As I already told you, please fork the repo and make all the changes that you need to and then open a pull request so that I can apply them all into the stable master branch of pyrtfolio. Thank you!

typhoon71 commented 4 years ago

Done. I made 2 pull request, since there's also investpy==0.9.14 but I don't know if there's a reason for it to be locked.

alvarobartt commented 4 years ago

No, there is no reason for investpy to be limited to the 0.9.14 version. Also you need to create the pull request to the master branch, since you created the pull requests into your own fork.

typhoon71 commented 4 years ago

Will do, I knew I'd do it wrong.

typhoon71 commented 4 years ago

Now?

alvarobartt commented 4 years ago

Steps: New Pull request at https://github.com/alvarobartt/pyrtfolio/pulls -> Compare across forks -> Select your fork -> Describe all the feature, fixes, etc that you solved within your fork

alvarobartt commented 4 years ago

No, check the steps I just mentioned you! Thank you!

typhoon71 commented 4 years ago

Should I choose master or developer?

alvarobartt commented 4 years ago

developer