alvaromontoro / TourGuide

JS module that helps generate step-by-step instructions and demos in an easy way

MIT License

20 stars 4 forks source link

Feature/initial configs #22

Closed dulcetti closed 5 years ago

dulcetti commented 5 years ago

19

Add initial config to:

Babel
ESLint
CSScomb
editorconfig
postcss
Package.json

Next features

Add Webpack
Change tests of Karma to Jest

alvaromontoro commented 5 years ago

That's a lot of changes. Let me review before I approve the merge.

dulcetti commented 5 years ago

No problem. The tests don't work yet. I will resolve.

dulcetti commented 5 years ago

I putted one configuration of eslint. Review and if you can, change it or tell me ;)

alvaromontoro commented 5 years ago

@dulcetti This is a ton of code to review. Some of the changes seem unnecessary (csscomb, editorconfig); and some other are nice, but seem unrelated and maybe would be better in a different ticket/PR (lint, testing). I will look into it during the weekend.

dulcetti commented 5 years ago

@alvaromontoro Well, I thinkthe editorconfig important, but ok.

Yeah, about tests I will create a Issue. You prefer create one PR for each setting? (lint, etc)