alvaromontoro / almond.css

Collection of CSS styles to make simple websites look nicer
MIT License
1.14k stars 35 forks source link

`import "almond.css/dist/almond.min.js"` doesn't work #90

Closed yumafuu closed 2 weeks ago

yumafuu commented 2 weeks ago

Describe the bug

I think the path for npm installation in the README is wrong.

I think the import ext is css. The file that exists in dist is css

$ bun i almond.css
$ ls node_modules/almond.css/dist
almond.css  almond.lite.css  almond.lite.min.css  almond.min.css

So this worked.

- import "almond.css/dist/almond.min.js"
+ import "almond.css/dist/almond.min.css"

Steps to reproduce

Expected behavior

Screenshots

Devices

Additional context

alvaromontoro commented 2 weeks ago

Good catch. This is a mistake in the README file.

If you are participating in Hacktoberfest, feel free to make the change, and I'll approve it. If not, I will push the change shortly.

Thanks for letting me know.

yumafuu commented 2 weeks ago

@alvaromontoro

I made a PR https://github.com/alvaromontoro/almond.css/pull/91

Thank you for the opportunity to contribute!

alvaromontoro commented 2 weeks ago

@yumafuu Thank you for catching the issue and contributing!

I just merged the change.