alvarop / usb_c_cable_tester

738 stars 21 forks source link

Explain files inside jlcpcb.zip used for ordering #4

Closed ewenmcneill closed 1 year ago

ewenmcneill commented 1 year ago

Thanks for creating this project, and making it available for people to order themselves. And for creating the ORDERING guide. As my first PCB order ever, and first order from JLCPCB, it had nearly everything I needed to successfully make the order.

It turns out, based on the question I got from JLCPCB, that I should have unzipped the jlcpcb.zip and not uploaded it directly (instead uploading GERBER-usb_c_cable_tester.zip found inside jlcpcb.zip... as it says in the instructions). But uploading jlcpcb.zip directly "worked" (to get what looked like a sensible PCB preview) because the Gerber files are also in the gerber directory of jlcpcb.zip. However uploading the main jlcpcb.zip confuses the JLCPCB operators as they now have two copies of the Gerbers, and hence need to ask for confirmation. (Which I was able to provide, once I double checked the files were identical.)

So I think it'd be good to have a reminder at the top of the ordering page that you need to unzip jlcpcb.zip to find the files referenced in the instructions. Feel free to modify/reword as suits (or discard if you'd rather not include it); I just figured a PR with "can merge as is" text was better than creating an issue and leaving it for you t figure out wording :-)

Ewen