search

alvarotrigo / react-fullpage

Official React.js wrapper for fullPage.js https://alvarotrigo.com/react-fullpage/
GNU General Public License v3.0
1.29k stars 178 forks source link

[Breaking change] Typescript types error 0.1.22 #304

Closed tonytoth closed 2 years ago

tonytoth commented 2 years ago

Description

Link to isolated reproduction with no external CSS / JS

Steps to reproduce it

"@fullpage/react-fullpage": "^0.1.22" has 2 mandatory fields which I am not sure they should be:

If you have a look at declaration file:

interface FullPageProps extends fullpageOptions {}

export interface fullpageOptions { cards: boolean; cardsOptions: CardsOptions; }

alvarotrigo commented 2 years ago

Thanks for reporting it!! 👍 Fixed on the dev branch!

nashfisher commented 2 years ago

Any idea when this update will be released?

alvarotrigo commented 2 years ago

There's a major version change in fullpage.js that has been released yesterday. Version 4.

There are still some issues so I'll wait until I extinct the main fires to merge it on react-fullpage.js too.

alvarotrigo commented 2 years ago

Fixed in 0.1.25! 🎉