search

alvarotrigo / react-fullpage

Official React.js wrapper for fullPage.js https://alvarotrigo.com/react-fullpage/
GNU General Public License v3.0
1.29k stars 178 forks source link

Made cards and cards Options Props optional because they cause a build time (Type Check) error in typescript when not being specified explicitly #313

Closed AbobkerElaghel closed 2 years ago

AbobkerElaghel commented 2 years ago
  1. Make sure to commit it to the dev branch!
  2. Read https://github.com/alvarotrigo/fullPage.js/wiki/Contributing-to-fullpage.js
alvarotrigo commented 2 years ago

This was already merged on the dev branch on this commit

alvarotrigo commented 2 years ago

Thanks anyways! 👍

AbobkerElaghel commented 2 years ago

of course, but the master branch still has them required? and as u know, when you install a package the master branch gets downloaded.

should I Re-open the pull request to the master branch.

alvarotrigo commented 2 years ago

Yeap, I'm aware of that.

But we only merge on the dev branch when we have more than one issue fixed. Then we create a new release with all of them. It makes it easier to track changes and so on.

I'll merge this into the master when we update react-fullpage to the latest fullpage.js version 4. In about 2 weeks.