search

alvations / pywsd

Python Implementations of Word Sense Disambiguation (WSD) Technologies.
MIT License
744 stars 132 forks source link

Update __init__.py #68

Closed DASHANANT closed 3 years ago

DASHANANT commented 3 years ago

110781072-683ae300-82a0-11eb-904d-9370b5f500f6

arademaker commented 3 years ago

This PR can be accepted? this is a serious error preventing the use of the lib.

goodmami commented 3 years ago

I don't think this PR should be accepted.

The problem is that the newer https://github.com/goodmami/wn module took over the wn name on PyPI, but it is not backwards compatible with the previous wn module, which was @alvations's old and unmaintained https://github.com/nltk/wordnet/ module. This PR attempts to fix the situation by (partially) removing that dependency and instead importing the NLTK's wordnet module, but the issue was already fixed in 20885bf347e4016174de8a0eaf593d7a3f37b28c by pinning the version of wn to 0.0.23 (the latest version on PyPI from the old wn). But those changes never made it into a release on PyPI. That is, you shouldn't see the ImportError if you clone and use the PyWSD source from GitHub, but if you do pip install pywsd you'll get an old, broken version.

The proper fix is for @alvations to bump the version to something new, like 1.2.5 or 1.3, and make a release on PyPI.

goodmami commented 3 years ago

Sorry, forgot to add: thanks to @DASHANANT for the effort of putting together the PR. It's just not what is needed to fix the problem.

DASHANANT commented 3 years ago

Thank you , I Understood

goodmami commented 3 years ago

@DASHANANT to fix your problem you can also try running the following:

python -m pip install -U wn==0.0.23

See also #65. Good luck!