alvatip / Nordzy-icon

Nordzy is a free and open source icon theme for Linux desktops using the Nord color palette from Arctic Ice Studio and based on WhiteSur and Numix Icon Theme.
GNU General Public License v3.0
312 stars 13 forks source link

[BUG] Symbolic icons don't change color in qt apps #146

Closed Readf0x closed 1 month ago

Readf0x commented 11 months ago

Describe the bug Symbolic icons don't change color in some applications, mainly qt apps. This is because most symbolic icons use element styles to set the color to nord0. To fix, just change the color to currentColor, but don't use classes to change it to nord0 anyways, as this will prevent some applications from changing the icon color.

To Reproduce Set qt icon theme to nordzy and open a qt application

Expected behaviour Icons can change color.

Screenshots image image image

Desktop I'm using Gnome 42 on Pop!_OS (debian), but this does affect all distributions.

alvatip commented 11 months ago

Thanks for noticing, I will take a look at that

alvatip commented 11 months ago

Hey @Readf0x, I was wondering which theme are you using ? Don't ask me why, that was some years ago, and I was less experienced, but I encountered an issue and I chose not to use currentColor, instead I am changing the color when installing a theme. So symbolic icons in Nordzy are set to Nord0(dark) and symbolic icon in Nordzy-dark are set to Nord6 (light)

PS: Yes, I know that the name are counter intuitive, when I named them I thought Nordzy for overall light theme (=> so dark symbolic icons) and Nordzy-dark for overall dark theme (=> so light symbolic icons) :stuck_out_tongue:

Readf0x commented 11 months ago

I'm using the Nordic theme for my GTK theme. Other than that I'm using qt5 settings to manually change the colors to match the nord theme, since there really aren't that many qt themes online.

I didn't know there was a Nordzy dark, actually... That would've saved me so much time... 🤦

Readf0x commented 11 months ago

Upon further inspection, this affects GTK apps as well.

image

I would assume that when text is using the selected color, so should symbolic icons. However I'm no expert on GTK, so it's entirely possible I'm wrong.

alvatip commented 11 months ago

Damn! Thanks for reporting it, I will try using currentColor, hoping it solve the issue :stuck_out_tongue:

alvatip commented 11 months ago

I believe I found the fix, I don't think I will have time to do it today nor this weekend, so it will most likely be on Monday

alvatip commented 11 months ago

@Readf0x , I brought some changes to the icons, Screenshot_20230719_134849 Here is what I see in kvantum, using Nordic theme, maybe you can confirm that changes in the last commit were indeed successful ? Thanks

Edit: I should mention that I was able to reproduce the issue in kvantum which is why I used it as a reference to make the modification