search

alvatip / Nordzy-icon

Nordzy is a free and open source icon theme for Linux desktops using the Nord color palette from Arctic Ice Studio and based on WhiteSur and Numix Icon Theme.
GNU General Public License v3.0
317 stars 13 forks source link

[FEATURE] Light icons variant for dark bar #47

Closed Hotteterre closed 2 years ago

Hotteterre commented 2 years ago

Hello, thank you for the great icons! I only experienced some problem using them with a light theme (Nordic Polar) and a dark bar: setting light icons, some of the ones on the bar result invisible, while with dark icons the latter are difficult to see in some applications.

Could you consider to release a variant of light icons for use with light theme and a dark bar? For example, as in Flat Remix (https://www.opendesktop.org/p/1012430).

Thank you so much for the great work!

alvatip commented 2 years ago

Thanks for your comment, I surely can do that, I will keep you updated here :wink:

alvatip commented 2 years ago

It should work fine with the last commit :wink: Could you maybe try and confirm ?

Hotteterre commented 2 years ago

Thank you, installing from source I can select the light and dark variants, and they work. But with the last version I have a new issue: if I install all the color variants, whatever color I select, I obtain default folders. Excuse me for bothering you, but I cant0t figurate if it depends from the package or from my settings...

alvatip commented 2 years ago

Yep, I think I made a mistake when modifying the install.sh file, I will check that Thanks for reporting, I am glad someone tells me that there is an issue so I can fix it :wink:

alvatip commented 2 years ago

I did a mistake in the name of a variable in my install.sh script. Now all should work perfectly, -t allow to install color theme and the -p option switch the panel color (if color is dark, panel will be light and vice versa) Could you please confirm that it work also fine for you with the last commit ? :smile:

Hotteterre commented 2 years ago

Wow, it's perfect! If I can ask: would be possible to install all the colors with all the light/dark variants? It'd be very convenient when installing (and updating) from a package manager: there would be no need to change anything, simply choose the color and the variant. Thank you so much for all! :smile:

alvatip commented 2 years ago

Sure, I will check that :wink:

alvatip commented 2 years ago

It should work fine using: ./install.sh -t or ./install.sh --total :+1:

Hotteterre commented 2 years ago

Yes!!! It works with --total, perhaps because -t is already used to select the theme?

alvatip commented 2 years ago

Thanks, that is completely right, I will leave the long option and remove the short -t so it does not overlap with the choice for the theme. I will close the issue when done 😉 Thanks for you contribution 👍

Hotteterre commented 2 years ago

Thanks to you for the fabulous work! :smile: