search

alvawei / smerge

3 stars 3 forks source link

Code readability #3

Open Juliusc01 opened 6 years ago

Juliusc01 commented 6 years ago

Ex: Match.java has some weird indenting with it’s fields. Also I think it looks better if you separate base, local, and remote variables all into their own lines. Also it’s good practice to put all the getters next to each other, and all the setters next to each other.

connerknight commented 6 years ago

Some of these things are not quite so important and could be just personal preference, so not essential to change. But they can help the reader to understand your code quicker and will make your code look clearer.

sarahsz commented 6 years ago

personally, I didn't find the style of the code to be too bad, there weren't any glaringly obvious issues like redundancy