alvindimas05 / LagAssist

Tools to analyse, prevent and resolve lag
https://modrinth.com/plugin/lagassist
8 stars 2 forks source link

InventoryDragEvent not handled correctly #6

Open hervidero opened 2 months ago

hervidero commented 2 months ago

Running PaperMC 1.20.4 (latest build =497 of that version).

[12:21:25 ERROR]: Could not pass event InventoryDragEvent to LagAssist v2.32 java.lang.IncompatibleClassChangeError: Found class org.bukkit.inventory.InventoryView, but interface was expected at org.alvindimas05.lagassist.gui.HopperGUI.onInventoryDrag(HopperGUI.java:175) ~[lagassist-2.32-build57.jar:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor594.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:77) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:git-Paper-497] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?] at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.20.4.jar:git-Paper-497] at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[paper-1.20.4.jar:git-Paper-497] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?] at net.minecraft.world.inventory.AbstractContainerMenu.doClick(AbstractContainerMenu.java:480) ~[?:?] at net.minecraft.world.inventory.AbstractContainerMenu.clicked(AbstractContainerMenu.java:382) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClick(ServerGamePacketListenerImpl.java:3056) ~[?:?] at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:58) ~[?:?] at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:25) ~[?:?] at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:54) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.4.jar:git-Paper-497] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1465) ~[paper-1.20.4.jar:git-Paper-497] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:194) ~[paper-1.20.4.jar:git-Paper-497] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:123) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1442) ~[paper-1.20.4.jar:git-Paper-497] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1365) ~[paper-1.20.4.jar:git-Paper-497] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:133) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1343) ~[paper-1.20.4.jar:git-Paper-497] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1232) ~[paper-1.20.4.jar:git-Paper-497] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[paper-1.20.4.jar:git-Paper-497] at java.lang.Thread.run(Thread.java:1583) ~[?:?]

Both LagAssist 2.32 release version as latest DEV build #57 (from actions) gives this error. It happens when any player drags an item in their inventory.

I can provide a list of all plugins if needed (in DM or discord if needed)

hervidero commented 2 months ago

I've checked the config and all hopper checks are set to false, still this event happens and is not handled correctly.

part of the config related to hoppers (removed remarks for clarity):

hopper-check:
  enabled: false
  reason: "&c&lLag&f&lAssist &e» &fHopper crafting has been disabled."
  # Disable by setting it to 0.
  chance: 0
  chunk-hoppers:
    enabled: false #true was the default
    mode: "RANDOM"
    define: "&eChunk &fHopper"
    filter:
      default:
      - "IRON_ORE"
      - "ROTTEN_FLESH"
      - "BONE"
      - "ARROW"
      gui:
        name: "&d&lHopper Filter"
        size: 18
    mob-hopper:
      maxtps: 0.0
      spawn-reasons:
      - "SPAWNER"
      - "NETHER_PORTAL"
      multiplier: 1
      filter-items:
        zombie: "ROTTEN_FLESH"
        creeper: "GUNPOWDER"
        skeleton: "BONE"
    sell-hopper:
      enabled: false
      prices:
        ROTTEN_FLESH: 10
        GUNPOWDER: 5.3
        BONE: 1

Only the chunk hopper setting was changed to false, but by reading the config the hopper-check is already set to false, so this should not be related.