search

alvinjiang1 / pe

0 stars 0 forks source link

0 value price accepted #4

Open alvinjiang1 opened 1 year ago

alvinjiang1 commented 1 year ago

Screenshot 2022-11-11 at 4.42.03 PM.png

Issue

When using the addprop command, users are able to add a property and list it for $0. I believe this could be a feature flaw, because in my opinion, properties that are added should not be allowed to be listed for $0. This could cause some listings to be invalid.

Steps to Reproduce

  1. Type the command: addprop -n Apartment -p 0 -a apartmentcomplex -d this is an apartment -o Somebody -ph 91234567.

  2. This property was succesfully added.

Suggestion

Do not allow 0 as a valid price for property

nus-pe-bot commented 1 year ago

Team's Response

If we disallow for $0, where would we draw the line of not permitting a certain price of the property? Should we disallow properties that are only $1? How about $0.01? Implementing this behaviour will open a can of worms that is unnecessary to deal with, and we trust that the user will input what they believe is correct, we should not be holding their hands and being overly strict about this.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I am inclined to disagree with the team's assessment of this flaw in the design of their product.

I believe that this was an instance of inadequate/bad design that decreases the quality of the product in a way that the product is less useful for the target user for normal usage. The target user is a property agent that wishes to match their buyers to high quality properties that fit the buyer's conditions. However, what happens when invalid properties (that are listed for $0 or for a small sum) are in the listing? There is a high likelihood that these properties show up consistently.

Perhaps while using the sortprops command to sorting by ascending price? Or it could be matching to a buyer with no lower budget?

I do not believe any can of worms would have been opened by regulating this portion of the application, even an arbituary $200 minimum asking price would have been fine, as it attempts to solve this problem. I would have wished to see a minimum price check to increase the quality of properties / buyers so that the product can better match the needs of the target user of property agents. Without which, I still believe this is a feature flaw of the app.