search

alvinjiang1 / pe

0 stars 0 forks source link

Buyers that do not have a specified price passes the filter #6

Open alvinjiang1 opened 1 year ago

alvinjiang1 commented 1 year ago

Screenshot 2022-11-11 at 4.56.06 PM.png

Issue

Even though price range is stated as an optional field in the UG, it shows up as Non-Specified in the application. The specifications of the filterbuyers command was phrased such that only when buyers fulfil all the specified filters will it appear in the filtered list. However, when i use the command to filter for only price, all the buyers with no specified price ranges appear, which contradicts the intended implementation specified by the UG.

Steps to reproduce

  1. Add some buyers without a specified price
  2. Type the command filterbuyers -p 300000
  3. Observe that these buyers are also displayed

Suggestion

  1. Make it such that the buyers with no valid price are do not pass the filter and are not displayed in the application (potentially works better for the intended usage by the target users). OR
  2. Specify in the UG that buyers with Non-specified price range will pass the filterbuyers -p filter.
nus-pe-script commented 1 year ago

Team's Response

We intended the filter commands to give more suggestions that may still fit the filter since the price range is unknown, but we agree that it was not specified correctly in our user guide. It makes sense that buyers without a price range are still shown, as logically it means that they do not have a preference for budget.

The buyer with "not specified" price range will only appear at the end of the buyer list, and the correct buyers will still appear at the top. Hence we believe it is just a minor inconvenience, and thus a low severity bug that can be clarified with a UG change.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: While I sympathise with the group's intent for the filter to be more generous. However, I am unable to infer this intent just by reading the UG. The function promises to filter all the valid buyers that pass the price filter, being the price being filtered is within the price range of the user, as can be seen in the screenshot below. Screenshot 2022-11-15 at 4.00.07 PM.png

However, the actual behaviour is such that applying the price filter will always output buyers with Non-specified price ranges. Unfortunately, that is still a functionality bug, as the intended output as described by the UG is different from the actual output. I'm very sorry regarding this, but I do not think this bug can be considered a documentation bug, even though it could very well have been rectified by changing the documentation.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Upon establishing that this bug remains to be a Functionality Bug, I thereby continue to argue that this bug is in fact a severity medium bug. This is because of the following reasons:

Firstly, this bug will consistently appear without fail. Whether the team intended it or not, buyers with Non-specified price will always appear whenever a price filter is applied. While the user can continue to use the application, it can be considered more than just a minor inconvenience to them.

Next, it is reasonable to assume that the filter for price feature will be one of the most popular and commonly used commands. This is because property agents for a specific property definitely want to know which buyers that are currently using the application could potentially afford this property, and then contact them. It will inconvenience them should they encounter buyers who might not have this property within their budget but merely show up because they did not specify their desired price range. Coupled with the above reason that this bug will occur everytime this command is run, there will be significant inconvenience to the users as they have to manually spend time to sort through the "already filtered" list of buyers to then see who can really afford the property, which also somewhat defeats the purpose of the command.

As such, I believe this bug remains a medium severity bug.