search

alvintan01 / pe

0 stars 0 forks source link

The object diagram for the player component does not adhere to standard notation #18

Open alvintan01 opened 3 years ago

alvintan01 commented 3 years ago

image.png

The object diagram for the player component does not adhere to standard notation. Access modifiers should be indicated with +-# and the variables indicated after a colon. i.e +name: String

nus-pe-bot commented 3 years ago

Team's Response

Hi, Thank you for your advice.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Class diagram does not adhere to standard notation

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

Perhaps the labels in the round circles could have been disabled in plantUML?

[original: nus-cs2113-AY2122S1/pe-interim#1087] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi, Thank you for your advice. will do.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: image.png

According to the module website, it cannot be considered as a single bug since these are 2 separate diagrams. Also, the original bug report is suggesting that the round circles can be disabled but for the diagram reported, it was referring to the format of the access modifiers as well as the data type. Hence, I disagree that this issue should be marked duplicate.