feat: Add database/page object properties

alvis / gatsby-source-notion

A Gatsby source plugin for content management with Notion using the official API.

MIT License

56 stars 6 forks source link

feat: Add database/page object properties #6

Closed tansongchen closed 2 years ago

tansongchen commented 2 years ago

Some previously ignored properties (archived, icon, cover) and corresponding tests are added to type definitions.

This will help users to quickly find their icon and cover for databases/pages, see #5 .

tansongchen commented 2 years ago

@alvis Any chance of reviewing this pr? 😉

conradlin commented 2 years ago

Would definitely love to try this enhancement, great job! How can we reference your fix while waiting for the official merge?

alvis commented 2 years ago

@tansongchen Thanks so much for the PR. I'm going to close it because Notion has introduced some API changes since the last release, so this PR probably won't work. However, I'm in a process of updating the plugin, and hopefully get it released in the coming days. It'll support cover and icon ofcoz!

tansongchen commented 2 years ago

This pr already works well in my website (https://github.com/tansongchen/tansongchen.github.io). Feel free to copy pieces of code when coming up with your own version! 😄 Looking forward to your update