search

alvises / FPPopover

FPPopover provides an alternative to the native iOS UIPopoverController, adding support for iPhone and additional opportunities to customize the look and feel of the popovers.
http://www.poeticoding.com/fppopover-a-customizable-uipopovercontroller-for-iphone-and-ipad/
Other
901 stars 250 forks source link

about arc #61

Closed CullenSUN closed 11 years ago

CullenSUN commented 11 years ago

Origin

//ARC-enable and disable support

if __has_feature(objc_arc)

@property(nonatomic,assign) id<FPPopoverControllerDelegate> delegate;

else

@property(nonatomic,assign) id<FPPopoverControllerDelegate> delegate;

endif

I believe should be this:

//ARC-enable and disable support

if __has_feature(objc_arc)

@property(nonatomic,weak) id<FPPopoverControllerDelegate> delegate;

else

@property(nonatomic,assign) id<FPPopoverControllerDelegate> delegate;

endif

CoderSpinoza commented 11 years ago

I endorse this too. Why aren't there any comments on this post?

alvises commented 11 years ago

fixed. is in the last commit.