alvises / FPPopover

FPPopover provides an alternative to the native iOS UIPopoverController, adding support for iPhone and additional opportunities to customize the look and feel of the popovers.
http://www.poeticoding.com/fppopover-a-customizable-uipopovercontroller-for-iphone-and-ipad/
Other
902 stars 250 forks source link

border=NO doesn't work when FPPopoverNoArrow #86

Open jneiluj opened 11 years ago

jneiluj commented 11 years ago

When selecting border = NO and arrowDirection = FPPopoverNoArrow, the top of fppopover still display even if viewController.title = nil.

This issues is reproduced only with FPPopoverNoArrow

delanohelio commented 10 years ago

In FPPopoverView.m change line 507: contentRect.origin = CGPointMake(10,30) to: contentRect.origin = CGPointMake(10,10)

horaceho commented 10 years ago

My fix is to add one more checking at FPPopoverView.m line 511:

    if (self.border == NO) {
        contentRect.origin = CGPointMake(10, 10);
        contentRect.size = CGSizeMake(self.bounds.size.width-20, self.bounds.size.height-20);
    }

The unwanted title will be re-created if pushing a `UINavigation`` into FPPopover