alvistack / ansible-role-cri_o

Ansible Role for CRI-O Installation
Apache License 2.0
21 stars 6 forks source link

Missing vars for ubuntu-22.04 #4

Open prophet60091 opened 5 months ago

prophet60091 commented 5 months ago

Not sure if intentional or not but latest release doesn't have a ubuntu-22.04.yml file included, and without a definition in the call it can't find any vars, but even defined it can't because it's not there: ansible.builtin.include_role: name: ansible-role-cri_o vars_from: "{{ansible_facts['distribution'].lower()}}-{{ansible_facts['lsb']['release']}}.yml"

hswong3i commented 5 months ago

Somehow I didn't use any {{ansible_facts['lsb']['release']}} across all of my Ansible Roles, see https://github.com/search?q=repo%3Aalvistack%2Fansible-role-cri_o%20lsb&type=code

Moreover, our vars/ubuntu-22.04.yml exists in both develop and master branch:

Most likely you had did some local customization about how to use this Ansible Role, may you share more code about how you setting it up?

prophet60091 commented 5 months ago

So, it's weird to me because I see it in the repo plain as day but I have a requirements.yml with

hswong3i commented 5 months ago

Please don't use 5.4.0... It tooooo old...

Please refer https://github.com/alvistack/ansible-role-cri_o/blob/master/ansible-galaxy-requirements.yml about how I set it up with scm + GIT + develop branch.

prophet60091 commented 5 months ago

Yeah I thought so too but: image should be something to use in most cases, was my thinking. Thanks for the tip, though!