search

alvr-org / ALVR

Stream VR games from your PC to your headset via Wi-Fi
MIT License
5.3k stars 474 forks source link

feature request: Configurable color space #2426

Open nowak-pl opened 2 days ago

nowak-pl commented 2 days ago

Currently ALVR sets color space to DCI-P3 in client. https://github.com/alvr-org/ALVR/blob/4d0d0ce59ac6ffe34b4e19f5fc8bfe25f6ab8202/alvr/client_openxr/src/lib.rs#L245

It would be nice to have selectable color space in streamer because content authored in Rec. 709 or sRGB doesn't look the best when expanded to P3 without proper conversion and then clipped to HMD LCD panel native color space.

zarik5 commented 2 days ago

We are limited by the codec standards. It is best not to needlessly change the color space before encoding because that will exacerbate color aliasing (banding).

Or I may be misinterpreting your question. We could add an option on the streamer to instruct the client to use a specific color space.

nowak-pl commented 2 days ago

I'm only talking about sending to client which color space should it use in set_color_space call, no conversions on either end.

zarik5 commented 2 days ago

Yeah it can be done. There is a openxr extension to do that. I'll accept PR to implement it.