search

alvr-org / ALVR

Stream VR games from your PC to your headset via Wi-Fi
MIT License
5.56k stars 493 forks source link

wip: replacing x264 with openh264 #2452

Closed grillo-delmal closed 1 month ago

grillo-delmal commented 1 month ago

I started this mostly to see how hard could it be, and even if I got to a point where it compiles (if you have the dependencies available),it crashes when forcing SWEncoding...

Mainly sharing it cos I'm short in time to deal with this and I'm curious to see if someone knows what's wrong with it, but I might continue with this later

The-personified-devil commented 1 month ago

What would the advantage of openh264 be over x264 tho?

zmerp commented 1 month ago

I think i'd close this just because openh264 has much worse performance than x264. Openh264 is MIT which is better but most definitely unusable, given that x264 has barely the minimum performance required for VR.

grillo-delmal commented 1 month ago

What would the advantage of openh264 be over x264 tho?

grillo-delmal commented 1 month ago

What would the advantage of openh264 be over x264 tho?

I doubt there would be any other than making the app easier to distribute.

I think i'd close this just because openh264 has much worse performance than x264. Openh264 is MIT which is better but most definitely unusable, given that x264 has barely the minimum performance required for VR.

I've heard this argument too, and tbh, I agree, but at the very least i'd like to see it for myself :)

zmerp commented 1 month ago

I doubt there would be any other than making the app easier to distribute.

It's true. But right now given the very poor performance of software encoding, it's is just a gimmick for users to try out, and these users don't really care about licensing.

The-personified-devil commented 1 month ago

Tbh it runs pretty good if you have like 20 hwthreads to spare

zmerp commented 1 month ago

Given that the target audience is laptop users, i doubt that