firewall script doesn't correctly add service to all active zones - Githubissues

alvr-org / ALVR

Stream VR games from your PC to your headset via Wi-Fi

MIT License

5.55k stars 492 forks source link

firewall script doesn't correctly add service to all active zones #2508

Open yobson1 opened 1 week ago

yobson1 commented 1 week ago

Description

When troubleshooting the same problem described here I noticed when going into my firewall settings the service was created and was enabled for the libvirt zone but not the public zone. https://github.com/alvr-org/ALVR/blob/f86d34ec21a69eb0446ad8d1499612c20802f791/alvr/xtask/firewall/alvr_fw_config.sh#L13 The output of this on my machine is just libvirt.

❯ firewall-cmd --get-active-zones | grep -P '^\w+.*\w$'
libvirt

The firewall-cmd command on it's own is:

❯ firewall-cmd --get-active-zones
libvirt
  interfaces: virbr0
public (default)
  interfaces: enp40s0

So it would seem that regex needs some attention.

General Troubleshooting

[x] I carefully followed the instructions in the README and successfully completed the setup wizard
[x] I read the ALVR GitHub Wiki

Environment

Hardware

https://linux-hardware.org/?probe=057c9f6d92

Installation

ALVR Version: 20.11.1

Install Type:

[ ] Packaged (exe, deb, rpm, etc)
[ ] Portable (zip)
[x] Source (alvr-nvidia AUR)