refactor(client_openxr): :recycle: Do not recreate OpenXR session

alvr-org / ALVR

Stream VR games from your PC to your headset via Wi-Fi

MIT License

5.55k stars 492 forks source link

refactor(client_openxr): :recycle: Do not recreate OpenXR session #2519

Open zmerp opened 1 week ago

zmerp commented 1 week ago

Avoid the need to restart the OpenXR session. This reduces the chances of connection issues. This PR is needed to move towards Vive eye/face tracking support that was previously disabled.

Combined eye gaze support is removed for Quest and Vive. For Pico, we force enable combined eye gaze.

Now the InteractionContext is always initialized with multimodal tracking enabled, and disabled after connection if it's disabled for server.

The-personified-devil commented 1 day ago

Also do all the additional sources get unregistered when the client goes back from using them to lobby to another streaming session not using them?

zmerp commented 1 day ago

Also do all the additional sources get unregistered when the client goes back from using them to lobby to another streaming session not using them?

They don't. Maybe we should do that. technically it's not that hard since we can call select_sources() again