Hand matting option sometimes doesn't follow toggle box when launching VR, after app was backgrounded at least once

alvr-org / alvr-visionos

Experimental visionOS client for ALVR - SteamVR on Apple Vision Pro!

MIT License

432 stars 31 forks source link

Hand matting option sometimes doesn't follow toggle box when launching VR, after app was backgrounded at least once #58

Open shinyquagsire23 opened 9 months ago

shinyquagsire23 commented 9 months ago

Sometimes the app doesn't fully clean up and seems to reuse the existing immersive scene, with incorrect settings? Or something, I'm not sure what it's doing.

shinyquagsire23 commented 9 months ago

This might actually be a visionOS bug because I just had it change mid-session after opening Control Center, lol

shadowfacts commented 9 months ago

Actually, I think I missed this in my PR review. Here, the GlobalSettings instance should be in an @ObservedObject in the app struct, so that SwiftUI tracks the dependency properly: https://github.com/alvr-org/alvr-visionos/blob/main/ALVRClient/ALVRClientApp.swift#L77

Or GlobalSettings could use @Observable, in which case the dependency would be picked up without needing the additional property wrapper.