Arm64/v8 Images - Githubissues

alvr / alpine-android

🐋 Small docker image for building & testing Android applications.

https://alvr.dev

Apache License 2.0

327 stars 52 forks source link

Arm64/v8 Images #10

Open samkhawase opened 3 years ago

samkhawase commented 3 years ago

Hi,

Thanks a lot for creating the slim alpine images for Docker. Would it be possible for you to add support for Arm64/v8 arch? I've an Apple Silicon M1 macbook and other images don't work on it.

I tried forking this repo, but didn't go far as there are a lot of changes required with credentials etc.

We could leverage the platforms argument of the Docker buildx action?

 - name: Build Android Base JDK${{ matrix.jdk }}
   uses: docker/build-push-action@v2
   with:
     context: ./docker
     file: ./docker/base.Dockerfile
     push: true
     tags: ${{ steps.docker_meta.outputs.tags }}
     build-args: |
       JDK_VERSION=${{ matrix.jdk }}
     # Limit to platforms supported by base image
     platforms: |
       linux/arm64/v8

Here is a PR the has the relevant build .yml file that builds for arm64/v8 arch: https://github.com/docker/setup-buildx-action/issues/54

alvr commented 3 years ago

Hi @samkhawase,

right now arm64 is not supported in Alpine AdoptOpenJDK images (AdoptOpenJDK/openjdk-docker#519) nor Amazon Corretto (corretto/corretto-docker#46) so is not possible to do right now, maybe in a future.

samkhawase commented 3 years ago

Ok, thanks. I'll keep an eye on the ticket on the AdoptOpenJDK board.

rizrmd commented 2 years ago

Is there any update on this ?

alvr commented 2 years ago

@samkhawase @rizkyramadhan I'm going to create tomorrow a test image using Liberica JDK instead of AdoptOpenJDK/Corretto because it seems that it will take a long time. I will let you know when it is ready.

alvr commented 2 years ago

Is not possible yet to generate arm64 images. build-tools package installs emulator package and is not yet available for arm64. It seems that it will be with the release of Artic Fox.