always-on / always

Always-On Relational Agents for Social Support of Isolated Older Adults
http://www.cs.wpi.edu/~rich/always
4 stars 7 forks source link

Spurious hand relax gestures block timeout speech repetition #437

Closed charlesrich closed 9 years ago

charlesrich commented 10 years ago

@ling In the normal operation of system, after a 10 or 15 second timeout, the agent repeats (once only) what it just said, prefixed by "So, ...".

Unfortunately, I noticed that this behavior does not work properly in the Nutrition plugin when (and only when) a page is being displayed. The agent says "So", but there is nothing following.

The reason is that after sending the page (see console log below), the plugin sends an extra "speech" message with no text, but only two gesture commands to relax the hands. Since the timeout repeats the last speech message, this causes the error.

Since, the hands are not being used in current implementation, could you please just remove the sending of this extra speech message?

Please make sure this applies to all scriptbuilder plugins.

Sent {"msg_type":"speech","msg_body":{"text":"<DELAY ms=\"500\"/> We can look at a sample <EYEBROWS DIR=\"UP\"/> <GESTURE hand=\"L\" cmd=\"BEAT\"/> page <EYEBROWS DIR=\"DOWN\"/> together . <GESTURE hand=\"R\" cmd=\"RELAX\"/> <GESTURE hand=\"L\" cmd=\"RELAX\"/> "}} Sent {"msg_type":"express","msg_body":{"expression":"Warm"}} Sent {"msg_type":"page","msg_body":{"url":"file:///C:/Users/rich/Documents/GitHub/always/core/agent/images/Nutrition-1-1.jpg"}} Sent {"msg_type":"speech","msg_body":{"text":" <GESTURE hand=\"R\" cmd=\"RELAX\"/> <GESTURE hand=\"L\" cmd=\"RELAX\"/> "}}

charlesrich commented 9 years ago

@zessiez

Just want to make sure this minor bug fix is not lost.

-CR

charlesrich commented 9 years ago

This may be a bit too complicated to fix and having the agent just say "So,..." is not so bad. So closing it.