search

alwaysbegrowing / telegram-standup-bot

Very simple telegram bot for submitting daily standups
https://stoodbot.vercel.app
MIT License
27 stars 12 forks source link

Update Username Display and Related Messaging #71

Closed Namaskar-1F64F closed 2 years ago

Namaskar-1F64F commented 2 years ago

Well, since my last fix was so well received, I decided to make it work more better hopefully. I noticed /members doesn't respect first/last names and I looked through the code and couldn't find any other place that seemed like it needed updating. There is one place that's using username to query the DB, but it seems like it's working fine with people who don't have a username set so far so 🦐

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/alwaysbegrowing/stoodbot/FmdAsmS8UkWqA7YrqzawucrnbofW
✅ Preview: https://stoodbot-git-fix-user-addressing-alwaysbegrowing.vercel.app

swindesr commented 2 years ago

Nice, but is the DB missing big chunks of user info or something?

Namaskar-1F64F commented 2 years ago

This specific issue is caused by people that do not have a username set in Telegram. Usernames are optional, but the code was using them for display purposes. A first name is required and a last name is optional.

image

image

Geczy commented 2 years ago

it looks like they are indeed broken, an empty username is passed to the tg link & the more button

if you want to merge this sooner than later, i can fix this in a later pr

image

Namaskar-1F64F commented 2 years ago

I never have seen or used the web interface 🙃