search

alwx / react-native-photo-view

Pinch-to-zoom view for React Native (both iOS and Android)
MIT License
816 stars 434 forks source link

UI Thread dropping frames on RN 0.51 #141

Open jjdp opened 6 years ago

jjdp commented 6 years ago

The ui thread frame rate dips when trying to load an image from a remote source. It was working fine on 0.49.5. Haven't tested on 0.50 since i skipped this one.

It basically waits for an image to load so the ui thread hangs. Very noticeable with large pictures. Easily testable with setting props.source={{uri: ''}} there are no hang ups

LcTwisk commented 6 years ago

Can you check If the changes in #139 fix the problem for you?

jjdp commented 6 years ago

still the same

ergunyasar commented 6 years ago

I'm experiencing exactly the same issue. #139 actually made it worse for me.I am using react-native-router-flux modal to show PhotoView. Everything was fine till the upgrade of RN 0.51. Now it hangs half way of the modal animation. With #139 All modal animations are gone.

wwwdata commented 6 years ago

Can confirm this problem as well.. Previously everything worked smoothly with RN 0.49. Did you guys now find a fix that works reliably?

jjdp commented 6 years ago

sadly no this lib seems unmaintained. I'm using pure JS for my use case atm.

cbjs commented 6 years ago

+1

musicode commented 6 years ago

anyone can run it on RN 0.53.3?

image

wcyiu commented 6 years ago

I also experience the same issue with "react-native": "0.55.4", "react-native-photo-view": "^1.5.2" and "react-navigation": "^2.5.5". Transition animation when navigating to a screen with PhotoView is very slow and stop at the middle. With #139 fixes, the screen actually stops before the transition happens.

tmjordan commented 5 years ago

139 does not help