search

alwx / react-native-photo-view

Pinch-to-zoom view for React Native (both iOS and Android)
MIT License
815 stars 434 forks source link

Doesn't work on android with react-native@0.42.3 #66

Closed TomPradat closed 7 years ago

TomPradat commented 7 years ago

On android simulator i have an error message : "Unable to resolve module react-native/Libraries/Components/View/ViewPropTypes"

I guess this is because of the following import in PhotoView.android.js. import ViewPropTypes from 'react-native/Libraries/Components/View/ViewPropTypes';

weijianfeng commented 7 years ago

I have the same problem.

th317erd commented 7 years ago

For now use this version in your package.json: "react-native-photo-view": "github:alwx/react-native-photo-view#383b8be6ef2444d74f9eae45359189e6d081de6e"

antseburova commented 7 years ago

When I use the recommended above version, the onLoad event on all of the images in my app stops firing. Do you have any idea why that happens?

th317erd commented 7 years ago

@antseburova No unfortunately I am not sure why the onLoad event is not firing... however I have ran into this issue before, and so have other people with other RN events, and sometimes clearing all modules, reinstalling them, and rebuilding the binary fresh can fix. You might start there. If that doesn't help you will just have to run it via a debugger and see where the disconnect is.

antseburova commented 7 years ago

Okay, thank you!

alwx commented 7 years ago

The fix has already been merged. https://github.com/alwx/react-native-photo-view/pull/82

spencewine commented 7 years ago

This still isn't working after this PR was merged today.