search

alwx / react-native-photo-view

Pinch-to-zoom view for React Native (both iOS and Android)
MIT License
816 stars 435 forks source link

Is there any reason not to use the latest PhotoDraweeView version? #69

Open dcmdestello opened 7 years ago

dcmdestello commented 7 years ago

As per https://github.com/alwx/react-native-photo-view/blob/master/android/build.gradle#L39:

dependencies {
    compile 'com.facebook.react:react-native:+'
    compile 'com.facebook.fresco:fresco:0.11.0'
    compile 'me.relex:photodraweeview:1.0.0'
}

We are using the 1.0.0 of PhotoDraweeView. Is there any specific reason not to bump the version to the latest 1.1.3?

dependencies {
    compile 'com.facebook.react:react-native:+'
    compile 'com.facebook.fresco:fresco:1.3.0'
    compile 'me.relex:photodraweeview:1.1.3'
}

A quick test in Android shows no problems and fixes some issues like #34.

vuquangthinh commented 6 years ago

Thanks god, you are here (y)

stokesbga commented 6 years ago

how does this solve issue for ios?

vuquangthinh commented 6 years ago

Open Android Studio, edit version of photodraweview to 1.1.3 in build.gradle of react-native-photo-view and click sync.