search

alwx / react-native-photo-view

Pinch-to-zoom view for React Native (both iOS and Android)
MIT License
816 stars 435 forks source link

Unable to resolve viewPropTypes. #99

Closed spencewine closed 6 years ago

spencewine commented 6 years ago

I saw PR #82 was merged to fix this recently, but it appears to still be broken. It is throwing the error below when reinstalling the package and running in IOS:

simulator screen shot sep 5 2017 3 12 42 pm

Setting the version to: "github:alwx/react-native-photo-view#383b8be6ef2444d74f9eae45359189e6d081de6e" in the package.json as found in #66 fixes the issue, but this issue was closed with the merge of #82 .

spencewine commented 6 years ago

issue resolved, realized the version of RN I was using required me to rollback to 1.2.0 here.

i8wu commented 6 years ago

thanks for the solution @spencewine , do you know what key features are missing from the older versions? This repo doesn't seem to have a release log.