alxpez / vuegg

dnd visual editor - mockups and code in one go!
https://vuegg.github.io
MIT License
2.34k stars 392 forks source link

chore: add Node.js 10 #27

Closed DanielRuf closed 6 years ago

DanielRuf commented 6 years ago

Description This adds Node.js 10 to the CI tests.

Motivation and Context Test the latest stable release of Node.js.

Types of changes

Checklist

DanielRuf commented 6 years ago

See https://github.com/nodegit/nodegit/issues/1490

DanielRuf commented 6 years ago

So it does not yet work with Node.js 10.

alxpez commented 6 years ago

@DanielRuf Thanks for your insterest,

Honestly nodegit is a bit of a pain at this point (every time I deploy a release, it takes around 5 minutes to build nodegit binaries from the soruce code), I have to do some test to see if I can get rid of it.

I'll close the PR for now

DanielRuf commented 6 years ago

I have to do some test to see if I can get rid of it.

This is not the issue but the incompatibility.

I would kept it open to track the status of the dependency and try a nodegit update when there is one available.

But I guess I'll try again in the next days and weeks.