search

alxwolf / ubios-cert

Manage SSL / TLS certificates with acme.sh (Let's Encrypt, ZeroSSL) for Ubiquiti UbiOS firmwares
MIT License
170 stars 20 forks source link

Script issues - support for UDMPro v2.4.23 #32

Closed mojo333 closed 1 year ago

mojo333 commented 1 year ago

  1. deploy.sh fails for me as I get the following when executing:

    root@UDMP:/data/letsencrypt/ubios-cert-main# ./deploy.sh
Unsupported model: UniFi Dream Machine Pro

    Adding an echo just before the case statement shows that ${MODEL} evaluates to just "UniFi" and hence why the case statement fails... something to do with spaces in the variable. Not sure how to fix this as I'm no bsh expert.

  2. ubios-cert.sh also needs updated code to handle UDMPro 2.4.23 as was done for deploy.sh - see excerpt below:

# When running in UDM SE / UDR, the applications are not running in containers
case "$(ubnt-device-info model || true)" in "UniFi Dream Machine SE"|"UniFi Dream Router")
    # But here, the same command will be executed but inside unifi-os container
    IS_UNIFI_2='true'
    ;;
esac
ausil commented 1 year ago

I have submitted a fix in PR #33 sorry I must have missed that bit when testing it late last night

mojo333 commented 1 year ago

I must have missed that bit when testing it late last night

I'm keen to get this working, so thanks for your support on this.