alyf-de / banking

An Open Banking Integration with ERPNext
GNU General Public License v3.0
38 stars 18 forks source link

Make "Match Voucher" clear and responsive #48

Closed barredterra closed 9 months ago

barredterra commented 11 months ago

Problem

We have too much data in the horizontal direction to fit into the "Match Voucher" tab as a table. On my big screen, I can only see five of seven columns, which makes it look a bit convoluted and requires horizontal scrolling, which is unusual.

Proposed solution

marination commented 11 months ago

Either bold, or green ticks infront of whatever is matching

marination commented 11 months ago

The first draft of the design:

@barredterra suggestions ? Maybe Reference Number can be on the next line? I did not want to make it too bulky vertically either.

Screenshot 2023-09-21 at 12 56 55 PM

Before:

Screenshot 2023-09-21 at 1 01 31 PM
barredterra commented 11 months ago

To represent the voucher in a compact way but still be able to make sense of it, I think we need the following values:

All except the voucher name should get highlighted if matching.

What if we make the layout similar to the bank transactions on the left side? It could be almost identical except we'd replace the Description with the Voucher Name.

marination commented 11 months ago

What if we make the layout similar to the bank transactions on the left side? It could be almost identical except we'd replace the Description with the Voucher Name.

@barredterra We have much more horizontal space on the RHS, so the exact same LHS leaves a lot of white space.

Party Name (links to party, link title set to party type),

Maybe users want to see the party as the title since it is a match parameter

barredterra commented 11 months ago

Whitespace isn't a bad thing per se, I guess. But rows are fine as well, as long as everything fits into the view.

Maybe users want to see the party as the title since it is a match parameter

With "link title" I meant the title attribute that's shown on long hover. Like this:

<a href="/app/customer/ABC" title="Customer">ABC</a>
marination commented 9 months ago

@barredterra I rethought this issue and we seem to be focusing on the wrong problem if not going about it wrong.

I think the table does a decent job at the moment and revamping that does not personally seem worth it to me. If there is a specific design you have in mind that solves our issues, please feel free to pitch it. I unfortunately could not come up with something much better.

barredterra commented 9 months ago

Makes sense, thank you.

One thing we should still consider is highlighting the matched values, instead of the info icon. I guess that could be done via custom formatters in the data table?

marination commented 9 months ago

One thing we should still consider is highlighting the matched values, instead of the info icon. I guess that could be done via custom formatters in the data table?

Agreed