alyf-de / banking

An Open Banking Integration with ERPNext
GNU General Public License v3.0
40 stars 21 forks source link

fix: Set default country in kosma popup based on selected company #78

Closed marination closed 11 months ago

marination commented 11 months ago

Depends on https://github.com/alyf-de/banking-admin/pull/28

The country of the selected company will be preselected in the Kosma popup: 2023-11-03 14 03 24

If the country is not supported (eg. An indian company is chosen), it will default to no preselection. Kosma decides the default:

Screenshot 2023-11-06 at 10 58 17 AM

What's done:

barredterra commented 11 months ago

I could imagine, say, an Indian company having a German bank account (among others). When the company's country is not available, can we just not prefill anything instead of raising an error?

marination commented 11 months ago

Good point. I'll default to not sending any country if the country is not in the list of approved country codes