search

alyf-de / banking

An Open Banking Integration with ERPNext
GNU General Public License v3.0
37 stars 18 forks source link

fix: amount allocation with space issue #79

Closed bhavesh95863 closed 8 months ago

bhavesh95863 commented 8 months ago

Issue in Amount Allocation - For currencies with format which have spaces after thousand, Current Split was getting only the first character as amount , not the whole amount. https://drive.google.com/file/d/1RBiGxycgobSdzTL2MGHvARDlVcInOKWM/view?usp=sharing

Solution - Updated Split Function which gets the complete amount. https://drive.google.com/file/d/1cSg5DM1wRfU9IPdDEVwtC0GURx1EXBNC/view?usp=sharing

barredterra commented 8 months ago

Thanks for reporting. I think we shouldn't store the amount as a formatted string in the first place. Fixed here: https://github.com/alyf-de/banking/pull/80