feat: Business Letter - Githubissues

alyf-de / erpnext_germany

ERPNext customizations for German companies

GNU General Public License v3.0

35 stars 20 forks source link

feat: Business Letter #21

Closed scdanieli closed 3 months ago

scdanieli commented 5 months ago

https://github.com/alyf-de/erpnext_germany/assets/23150094/d5a5c586-9bdd-4c98-8372-85677db2492e

To-do

[ ] Migrate to version 14
[x] Update README
[x] Roles and Permission (?)

barredterra commented 4 months ago

Let's use "Employee" instead of "All" (which would include Customers, Suppliers or other portal users)

scdanieli commented 4 months ago

I just noticed that the translation is not functioning as intended. Comments will be saved in the language of the user who submits or cancels the Business Letter. I don't see a way to adjust this without modifying the framework.

barredterra commented 4 months ago

We should probably also

[x] add an "Address Display" field, in order to make it easier to use the address via print format builder
[x] fetch the contact email into a field "Email ID", in order to get it pre-filled in the email dialog
[x] enable "Print Hide" for all fields that are not supposed to get printed on the letter (and "Report Hide" where it makes sense)

scdanieli commented 3 months ago

@barredterra all suggestions implemented ...

barredterra commented 3 months ago

@mergifyio backport version-14

mergify[bot] commented 3 months ago

backport version-14

✅ Backports have been created

* [#24 feat: Business Letter (backport #21)](https://github.com/alyf-de/erpnext_germany/pull/24) has been created for branch `version-14`