Update options.from modification for nodemailer

alykoshin / gmail-send

Minimalistic module to send email using GMail

MIT License

89 stars 26 forks source link

Closed sk8ersteve closed 3 years ago

sk8ersteve commented 7 years ago

Code incorrectly uses options.from twice instead of options.from options.user

alexgvozden commented 6 years ago

this should be merged as it relieves the bug using from

reqshark commented 5 years ago

backup has now arrived on scene but its like years after the crime

🚓 🚓 🚓

the gmail-send program is broken and unsuable without this PR.

the from text is completely ruined when you send email, and it's been like that forever

personally i have applied this patch in my software the whole time

but if this ever got merged 🔥:fire: :fire:

I could stop using the patch from this PR and switch back to this project 🚀

honeymaro commented 5 years ago

Please merge this.

softremake commented 4 years ago

@alykoshin Almost 3 years since this patch was made but new users still have to dig into the code to figure out why it's not working...

gabrielmaldi commented 3 years ago

This fixes the bug which prevents setting the from name.

gabrielmaldi commented 3 years ago

Thanks a lot, @alykoshin! 🚀

alykoshin commented 3 years ago

you are welcome.

Thanks for PR and sorry for long silence.

gabrielmaldi commented 3 years ago

EDIT:

Is there a release to npm planned? Thanks again.

alykoshin commented 3 years ago

Also updated dependencies to latest versions; you may upgrade to gmail-send@1.8.14.

reqshark commented 1 year ago

oh great, glad to see this one landed. thanks @alykoshin