alyosha-tas / GBAHawk

Gameboy Advance Emulator fork of BizHawk
Other
12 stars 2 forks source link

'Power' button doesn't work in multi-GBA situations #26

Closed RetroEdit closed 6 months ago

RetroEdit commented 7 months ago

With multiple GBAs open, I tried both of the power buttons in virtual pad and nothing happened. I also tried binding it to the controller and creating a TAStudio movie.

I'm used the multi-disk bundler to load up Game & Watch Gallery 4 along with the BIOS (since it's a game with Single-PAK multiplayer game).

alyosha-tas commented 7 months ago

Proper power cycling in linked mode actually isn't supported currently, I would need full subframe support first since the frames would no longer line up after power cycle.

Do you have a particular use case in mind?

RetroEdit commented 7 months ago

In this case, if I were to do a full completion Game & Watch Gallery 4 TAS, I would need to power-cycle the dependent GBA multiple times to initiate new link transfers when playing different subgames.

alyosha-tas commented 7 months ago

would power cycling both at the same time be sufficient? That much I can do pretty easily.

RetroEdit commented 7 months ago

Yes, that would technically work, but it's not ideal, since it's a faster TAS if you never power-cycle the primary GBA.

To me, I don't understand how they can line-up on the first simultaneous power-cycle, but power-cycling the second GBA would introduce additional complexity. Is it just a matter of added subframe support to line the second GBA up a single time when it power-cycles, or would the changes have to be more involved than that? Or am I not understanding what subframe support means in this context?

(Side note: in my niche situation, I probably don't need the second GBA to press any inputs, just to turn on. But that detail probably shouldn't affect implementation).

Just to be clear -- this isn't high priority for me, since a full Game & Watch Gallery 4 TAS is a huge undertaking that I'm unlikely to finish anytime soon.

alyosha-tas commented 7 months ago

The first frame after power on is shorter than the others, so it adds some difficulties, but I thought up a way to do it so I'll work on it in the next week or two.

alyosha-tas commented 6 months ago

@RetroEdit console reset is now enabled in master branch, if you can build from source please test your use case.

RetroEdit commented 6 months ago

No issues here after testing.