alyosha-tas / GBAHawk

Gameboy Advance Emulator fork of BizHawk
Other
12 stars 2 forks source link

TAStudio columns are odd with multi-GBA #27

Closed RetroEdit closed 6 months ago

RetroEdit commented 7 months ago

When I press buttons in recording mode, the columns are mislabeled (the game processes the presses as expected). This seems likely to be a rendering bug caused by an extra ! column to the left.

Also, whenever I click on the columns for player 2, it just visually fills the whole column with the column's letter instead of properly setting the button.

alyosha-tas commented 7 months ago

Having trouble reproducing this one, can you give any more info?

RetroEdit commented 7 months ago

Sure, these are some repro steps:

1) Open GBAHawk 2.1.0 (I started with a fresh extraction of the released file) 2) (I paused the emulator and set up the GBA firmware to be in the Firmware path) 3) The first time, I was playing Game & Watch Gallery 4, but this time I choose Donkey Kong Country. 4) I opened Tools > Multi-disk Bundler and choose System: GBAL, then chose DKC for the first entry and GBA BIOS as the second one and pressed Save and Run (relevant XML) 5) I opened Tools > TAStudio (image attached, note the extra ! column to the left)

GBAHawk_issue_000027.zip

I can compile it myself and look into it if you're still not able to reproduce.

alyosha-tas commented 7 months ago

The '!' is meant to be used for a yet to be implemented toggle for connecting / disconnecting the link cable, so it's supposed to be there.

I can't reproduce the misaligned inputs though or other glitches.

RetroEdit commented 7 months ago

I see. I can't test more currently, but I'll try and look at this in a few days.

To me it's fairly intuitive when I pressed 'B' for instance using recording mode, it did not render under the 'B' column, but maybe it's a local system-specific issue?

alyosha-tas commented 7 months ago

Weird. I tried every combination of recording mode, virtual pad input, keyboard input I could think of for player 1 and 2 and never got such an error. Yeah please let me know if you come up with anything

RetroEdit commented 6 months ago

Hm, seems like this was probably fixed in intervening builds.