search

alyosha-tas / GBAHawk

Gameboy Advance Emulator fork of BizHawk
Other
12 stars 2 forks source link

Solar Sensor support #28

Closed shenef closed 5 months ago

shenef commented 7 months ago

It seems GBAHawk currently doesn't support the Solar Sensor used in the Boktai games. Are there any plans to support it? I've tried TASing Boktai on BizHawk before but the implementation there has been pretty unstable / prone to desyncs. We'd be happy to provide feedback and testing for it.

alyosha-tas commented 7 months ago

Solar Sensor is supported it's just that the control is not mapped to anything by default.

You can go to config -> controllers -> analog controls after loading a Boktai game and bind it to what you want from there. I recommend setting deadzone to 0%. If the option isn't showing up, let me know the hash of the ROM you are using so I can add it to the Ddatabase.

I'm pretty sure it works as expected, but feedback welcome.

shenef commented 7 months ago

The options are indeed not showing up for me on this ROM: Boktai 1 JP ROM MD5: 9F1C1202ED1D856C5836CEE6818A171E SHA1: C51AD84E9403DB94CD18A14AC72F8367B52A0D7F Firmware: 300C20DF6731A33952DED8C436F7F186D25D3492

~~I'll check it for other ROMs later, there are at least 7 ROMs total when including the regions and revisions for all games. There also is an english translation patch for Boktai 3 (only came out in Japan) and a commonly used patch to control the light via a button combination. If you want we can compile you a list of hashes for patched and unpatched ROMs.~~

Edit: After checking all my unpatched ROMs, the Boktai 1 JP ROM posted above seems to be the only one that does not trigger the display of the options. TBH, it's not very intuitive to hide the options if the ROM is not detected. That also limits the options regarding patched ROMs.

alyosha-tas commented 7 months ago

Eventually I'll add options for users to add things to DB for cases like this, but for now I'll just add that JP one and whatever patched ones you want if you have a list of SHA1's.

alyosha-tas commented 7 months ago

@shenef do you have a list of patched ROM hashes you want to add? I added the JPN version of Boktai to the db already.

shenef commented 6 months ago

For now, no. Currently we are interested in GBAHawk mainly for TASing and for that, the JP release of each game is enough. For casual and RTA players we currently recommend mGBA and BizHawk anyway so it will not impact them. We also have an ExternalTool that initially did not run on GBAHawk but with some adjustments we are able to compile it for GBAHawk.

I'm currently checking for desyncs and any other problems with the current GBAHawk-native sensor implementation and will give feedback on that at some point.

alyosha-tas commented 5 months ago

Closing since original issue solved