search

alyssafrazee / polyester

Bioconductor package "polyester", devel version. RNA-seq read simulator.
http://biorxiv.org/content/early/2014/12/12/006015
90 stars 51 forks source link

Keep reads_per_transcript positive #49

Closed mourisl closed 6 years ago

mourisl commented 6 years ago

When using 'meanmodel=T', the reads_per_transcript in simulate_experiments() might be non-positive. If the number is non-positive, we will get warnings about NA from NB() and errors about "rep(...): invalid 'times' argument" when generating reads.

So I added a line to keep reads_per_trancript positive, is this valid?

Thanks, Li

alyssafrazee commented 6 years ago

Thanks so much for the pull request (and apologies for the delay in responding). This in general looks good to me -- have you tested this with your own data, and does it fix the problems you were seeing? (is it OK if basemeans is a very small decimal?).

mourisl commented 6 years ago

Yes, after this fixing I successfully generated 25 data sets.

alyssafrazee commented 6 years ago

👍 great, thanks! merging. @JMF47 can you get this into bioc?