search

alyssafrazee / polyester

Bioconductor package "polyester", devel version. RNA-seq read simulator.
http://biorxiv.org/content/early/2014/12/12/006015
90 stars 51 forks source link

Fixing non-deterministic behavior when seed is set and meanmodel logic #75

Closed NatPRoach closed 3 years ago

NatPRoach commented 3 years ago

Hello, This PR should fix a few problems I ran into when working with polyester. The first is that when meanmodel is set it draws from a normal distribution before the random seed is set. This made polyester non-deterministic, even when the seed was set. The second is that the logic for meanmodel only checked whether meanmodel was passed as an extra, not whether what was passed to meanmodel was TRUE. This meant that even if meanmodel = FALSE was passed, it was running as if meanmodel = TRUE was passed.

alyssafrazee commented 3 years ago

This is great! Thanks so much for tracking these things down and making the PR.