alyssaxuu / screenity

The free and privacy-friendly screen recorder with no limits 🎥
https://screenity.io
GNU General Public License v3.0
12.65k stars 978 forks source link

Highlighting cursor effect button in toolbar, when non-default effect selected #213

Open ceskyDJ opened 10 months ago

ceskyDJ commented 10 months ago

Hi @alyssaxuu! I realized that drawing tools (the last selected one, resp.) are active even the drawing menu is opened/active. I don't know if it is wanted behavior. I think if it is ok, Screenity should at least give me some graphical information in the toolbar about the activity of the drawing tool (e.g. blue circle background around button for opening drawing submenu). Now, I just don't know it is active and accidentally draw around the screen.

ceskyDJ commented 10 months ago

Maybe similar graphical warning should be active, when some cursor effect is set, too. Maybe blue background is just too much, but something like grey background or at least something little I can simply recognize would be fine.

ceskyDJ commented 10 months ago

One more thing... It would be good, if when I select something in drawing submenu, the icon of the button opener of this submenu is changed like cursor effects submenu does (if the tools from drawing submenu should be active even the menu isn't). It's a good way how to say, what tool I have activated, so what the mouse should do, when I click on the screen.

alyssaxuu commented 10 months ago

Sorry, the last release had a breaking change that caused the drawing tool to be active even when closed, but that is not the intended behavior. The drawing tools are only supposed to work when the menu is open, when it's closed the page should be interactive.

For cursor effects, I could consider adding a blue background of some sort if the cursor is not the default one. But it would definitely need to be subtle, I feel like unlike the drawing tools which are frequently toggled on / off, the cursors could be not only set throughout the recording, but users might (and do) use the same cursor type across recordings, to make their cursor more prominent with a highlight or to make sure their clicks are noticed.

For the latter, as I mentioned it's not the intended behavior for the drawing tools so that's why it doesn't behave the same taking in the icon like the cursors (it's the same with the blur tool). I consider draw + blur to be "modes" with their own separate tools, whereas cursor is more of a setting or preference.

ceskyDJ commented 10 months ago

Sorry, the last release had a breaking change that caused the drawing tool to be active even when closed, but that is not the intended behavior. The drawing tools are only supposed to work when the menu is open, when it's closed the page should be interactive.

That's nice. I thought it should work like this, but I didn't remember how it worked in older releases :(.

For cursor effects, I could consider adding a blue background of some sort if the cursor is not the default one. But it would definitely need to be subtle, I feel like unlike the drawing tools which are frequently toggled on / off, the cursors could be not only set throughout the recording, but users might (and do) use the same cursor type across recordings, to make their cursor more prominent with a highlight or to make sure their clicks are noticed.

Definitely! Only little thing I miss there is some kind of "warning" about activated non-default cursor effect. However, when I think of it more and more, it maybe don't need anything much expressive, when the icon of the toolbar button is changing according to the selected effect. At least something decent would be good, I think.

For the latter, as I mentioned it's not the intended behavior for the drawing tools so that's why it doesn't behave the same taking in the icon like the cursors (it's the same with the blur tool). I consider draw + blur to be "modes" with their own separate tools, whereas cursor is more of a setting or preference.

I get it. It's clear enough. I just was a little confused due to the bad behavior, when drawing tools were active all the time.