search

alyssaxuu / screenity

The free and privacy-friendly screen recorder with no limits 🎥
https://screenity.io
GNU General Public License v3.0
11.85k stars 914 forks source link

Load extension only on click #216

Closed anilshanbhag closed 7 months ago

anilshanbhag commented 7 months ago

I have an enhancement suggestion. It looks like Screenity is adding an iframe to each tab.

Screenshot 2024-02-10 at 12 49 03 PM Screenshot 2024-02-10 at 12 50 39 PM

Loom doesn't seem to insert an iframe into each tab. It would be good to ensure the extension doesn't take any resources until it is clicked on.

alyssaxuu commented 7 months ago

True, I could have the iframe load after the extension is opened. I think I had it added beforehand because I was having issues getting the camera and microphone permissions (which is done through the iframe), and it added an extra delay. I am still having to add extra elements to the DOM (just like Loom does) anyway to be able to toggle the extension.

In that same details page though (chrome://extensions/?id=kbbdabhdfibnancpjfhlkhafgdilcnji), under Side access, you do have the option to make it only access the tab and inject on click, which can be a workaround for now.

alyssaxuu commented 7 months ago

Fixed in the latest release, now the iframes only load after clicking on the extension button. Will go live on the Chrome Store in a day or so.

anilshanbhag commented 7 months ago

Awesome! thank you.